Multi-page webform invalid data with image #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is tested by @KarinG Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Data not submitted when upload image element is present in the multi-page webform setup.
Before
When having a multi-step form (with or without preview) and on one of the steps/pages we got a contact image field (file upload field), the submitted data do not keep the other changes but just the contact's image.
See drupal ticket for details - https://www.drupal.org/project/webform_civicrm/issues/3372150
After
Data submitted without any issues.
Technical Details
When you upload a file using a managed_file element, it involves AJAX requests behind the scenes, which trigger the form alteration hooks.
This patch prevents alterForm method from being called when you upload a file.
Comments
Drupal Ticket - https://www.drupal.org/project/webform_civicrm/issues/3372150