change .removeAttr('checked') to .prop('checked', false) in resetFields #902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addressing this issue:
https://www.drupal.org/project/webform_civicrm/issues/3381559#comment-15198961
Before
If you search for an Existing Contact, causing checkboxes to be autofilled, those checkboxes are not unchecked when clicking the 'x' to search for a different contact (full issue description and reproduction steps in the link above).
After
Checkboxes are unchecked as appropriate.
Technical Details
I haven't understood the second part of the line, I've just assumed that it should be retained:
.trigger('change', 'webform_civicrm:reset')
Comments
There are other uses of
.removeAttr
in the same file and elsewhere, which may or may not be correct. I haven't looked into changing them because I'm not aware of any specific bug which they might be causing.