Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing bracket. #912

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add missing bracket. #912

merged 1 commit into from
Sep 29, 2023

Conversation

puresyntax71
Copy link
Contributor

Related to the fix on #753. There was a missing bracket which led to the error:

Uncaught Error: Syntax error, unrecognized expression: [name*="civicrm_2_contact_1_address_"

@KarinG
Copy link
Collaborator

KarinG commented Sep 29, 2023

Thank you!

@KarinG KarinG merged commit b62d51b into colemanw:6.x Sep 29, 2023
3 of 4 checks passed
@MegaphoneJon
Copy link
Contributor

This seems identical to #903, I wonder how they were both mergeable?

@KarinG
Copy link
Collaborator

KarinG commented Sep 29, 2023

I knew I had seen this recently. Looking...

@KarinG
Copy link
Collaborator

KarinG commented Sep 29, 2023

And your commit is still the latest -> very odd how Github didn't flag this PR. Essentially we just merged nothing.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puresyntax71 @KarinG @MegaphoneJon