Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manually running unit tests against a drupal 8 civi PR #917

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

demeritcowboy
Copy link
Collaborator

Overview

There's already the ability to do this for a core PR. This extends it to allow doing it on a PR from the https://github.com/civicrm/civicrm-drupal-8 repo.

Before

can't (easily)

After

can (easily)

Technical Details

Comments

I've already run this on one in my own fork, which is always another way to do this kind of thing, but it's convenient to have it in the workflow dropdown here.

@KarinG
Copy link
Collaborator

KarinG commented Oct 13, 2023

Awesome - thanks Dave. Will merge and check on Merge Actions later

@KarinG KarinG merged commit 8a3e6f2 into colemanw:6.x Oct 13, 2023
4 of 5 checks passed
@demeritcowboy
Copy link
Collaborator Author

Thanks.
Yeah it might be worth liberally sprinkling session->wait calls around for these field not founds that keep coming up and see if that helps. Or replacing fillfield calls with a convenience func that waits first.

@demeritcowboy demeritcowboy deleted the drupal8-pr branch October 13, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants