Adjust for spacing change in emails in 10.3 #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demeritcowboy
force-pushed
the
103
branch
2 times, most recently
from
bd37e00
to
7e6528e
Compare
demeritcowboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some weird spacing happens in the email in the test for webform tokens. It's new in 10.3.
Before
No extra spacing at end of line.
After
Two spaces oddly added to end of some lines.
One newline that was previously oddly there is now no longer there.
Technical Details
I'm not sure this is on purpose upstream. At the same time the email being tested doesn't have any specific formatting and is originally one line run all together, and the spacing isn't what's important in the test. The tokens are still evaluating correctly.
It's the same version of the parent webform being used for both the drupals, so it's not something new there.
Comments