Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1403: Use 7.2 publicbrowser template #15

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

mikejritter
Copy link
Contributor

@mikejritter mikejritter commented Mar 20, 2024

What does this do?
Uses the 7.2 publicbrowser template

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1403

8.0 introduced some new fields which are not used by the materials profile: objectNameControlled, materialControlled, and objectCountGroupList. All these fields were brought in by the core public browser template and needed to be removed.

How should this be tested? Do these changes have associated tests?

  • Run the devserver
  • Create a collectionobject using the publicbrowser template and see that objectNameControlled, materialControlled, and objectCountGroupList do not exist
  • Git can also be used to verify the template only contains those changes compared to cspace-ui:
git diff --no-index ${CSPACE_UI}/src/plugins/recordTypes/collectionobject/forms/public.jsx src/plugins/recordTypes/collectionobject/forms/public.jsx

Dependencies for merging? Releasing to production?
Holdings is used in the public browser for materials but isn't present on the template. We should consider adding the indexed objectCount field to the template. contentConcepts also isn't usable in the template and should be considered for removal.

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

defaultMessage: 'Public Browser Template',
},
}),
sortOrder: 3,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messages and sortOrder can be removed.

Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 193477f into collectionspace:master Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants