Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim QA Updates #234

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Remove ulan and tgn from sources
  • Relabel fields
  • Claim Status use deaccessionapprovalstatus
  • Claim Documentation Group use doumentationgroup
  • Cultural Group pull from both archculture and ethculture

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1330

These are changes that came from the first pass of QA testing. Fairly minor changes, just updating sources for fields and updating labels.

How should this be tested? Do these changes have associated tests?

  • Check that npm run lint and npm run test still pass
  • Run the devserver npm run devserver --back-end=https://core.dev.collectionspace.org
  • Create a claim and see the update fields and sources

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested using core.dev as a backend

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (769ee9d) to head (5f26348).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   98.18%   98.17%   -0.01%     
==========================================
  Files         590      590              
  Lines       12682    12682              
  Branches     2593     2593              
==========================================
- Hits        12452    12451       -1     
- Misses        227      228       +1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit b1453d4 into collectionspace:master Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants