Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1496: Add objectCountUnit #236

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Adds objectcountunit termlist
  • Add objectCountUnit field

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1496

The objectCountUnit field that was supposed to be added when we updated the object count field group to be a larger group of fields. This allows it to be set in the forms for collection objects.

How should this be tested? Do these changes have associated tests?

  • Run npm run lint and npm run test
  • Start the devserver npm run devserver
  • Create a collectionobject with the objectCountUnit field filled out

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (4a51efa) to head (3b0e804).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         590      590           
  Lines       12682    12682           
  Branches     2607     2593   -14     
=======================================
  Hits        12452    12452           
  Misses        227      227           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 949b70c into collectionspace:master Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants