Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1399: RestrictedMedia #240

Merged

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Add RestrictedMedia record type
  • Add RestrictedMedia tests

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1399

This adds record type for RestrictedMedia, which is intended for use in workflows where there may be sensitive media which should not be immediately accessible.

How should this be tested? Do these changes have associated tests?

  • Run npm run lint and npm run test as a sanity check
  • Run the devserver npm run devserver
  • Test that the restrictedmedia resource can save and upload blobs

Dependencies for merging? Releasing to production?
This will eventually need a new type of view for the blob to prevent the thumbnail from automatically showing.

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally against the old PR

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (020cb7a) to head (2f77e03).
Report is 15 commits behind head on v10.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            v10.x     #240      +/-   ##
==========================================
- Coverage   98.17%   98.16%   -0.01%     
==========================================
  Files         597      605       +8     
  Lines       12720    12771      +51     
  Branches     2613     2620       +7     
==========================================
+ Hits        12488    12537      +49     
- Misses        229      231       +2     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikejritter mikejritter changed the base branch from master to v10.x October 29, 2024 18:34
@axb21
Copy link

axb21 commented Nov 19, 2024

Tested this and it appears to work fine. I was able to upload a restricted media image.

@mikejritter mikejritter merged commit 4753602 into collectionspace:v10.x Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants