Set row aria-label for search results #241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira:
The labels were previously only 'row' which is not descriptive of the row itself. This adds a label based on the example DRYD-1308 to each row in the SearchResultTables.
How should this be tested? Do these changes have associated tests?
npm run lint
andnpm run test
as a sanity checknpm run devserver --back-end=https://core.dev.collectionspace.org
{primary-column-data} selected row {index} of {total}
<a>
of the row as it hasrole=row
Dependencies for merging? Releasing to production?
This adds
intl
as a prop to SearchResultTable, which should be fine as it is already handled as part of the SearchResultTableContainer.Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter tested w/ core.dev as a backend