Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set row aria-label for search results #241

Merged
merged 4 commits into from
Oct 26, 2024

Conversation

mikejritter
Copy link
Contributor

@mikejritter mikejritter commented Oct 23, 2024

What does this do?

  • Sets the row label using the data from the highest order column

Why are we doing this? (with JIRA link)
Jira:

The labels were previously only 'row' which is not descriptive of the row itself. This adds a label based on the example DRYD-1308 to each row in the SearchResultTables.

How should this be tested? Do these changes have associated tests?

  • Run npm run lint and npm run test as a sanity check
  • Run npm run devserver --back-end=https://core.dev.collectionspace.org
  • Run a search and look at the resulting table
    • For each row, an aria-label should exist that reads something like {primary-column-data} selected row {index} of {total}
    • The aria-label is attached to the <a> of the row as it has role=row

Dependencies for merging? Releasing to production?
This adds intl as a prop to SearchResultTable, which should be fine as it is already handled as part of the SearchResultTableContainer.

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested w/ core.dev as a backend

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (020cb7a) to head (e3842aa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         597      597           
  Lines       12720    12739   +19     
  Branches     2613     2602   -11     
=======================================
+ Hits        12488    12507   +19     
  Misses        229      229           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mikejritter mikejritter merged commit b7eac0e into collectionspace:master Oct 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants