Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic object with current location report output type #420

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Updates mime type for Basic Object with Computed Location

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1451

This is updates so that xlsx output is set by default, as it has a way to both provide tabular data and thumbnails. As the workflow is still being tested, we're only adding this to a single report so that we can understand how it might work with, e.g. mail merge.

How should this be tested? Do these changes have associated tests?

  • Rebuild collectionspace
  • Create a collectionobject
  • Search for collectionobjects
  • Select the Basic object with current location report and see xlsx as the default output

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

@mikejritter
Copy link
Contributor Author

@ray-lee apparently I can't convert this to a draft, but I think we should hold off on merging this because I was supposed to do some additional testing of the report with multiple rows. I'll let you know when it's ready.

@kspurgin kspurgin marked this pull request as draft July 30, 2024 23:15
@kspurgin
Copy link
Contributor

I ended up here and was somehow able to convert it to a draft. I can change it back if that's annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants