-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Package with plone/meta - introduce only Plone 6 support #26
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this OK but I am not used to the new non-buildout-way of organizing the package. So I will request our meta-master a review.
In any case this requires increasing the version number to the next major version.
I'm not so sure that i would remove buildout at this point, for development setups. |
@MrTango is there a roadmap for the switch? I see the plone/meta config in many packages of the plone.xxx namespace. Plone's containers are pip-based. I didn't know what the right way was. I use pip based setups with mxdev in all my packages and have no problems. but this is a discussion with religious potential ;-) |
Ok, i had a look at the current meta setup, looks good and is recommended also for addons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we define the test Matrix here?
We state that this will run in Plone 6.0/6.1 and Python 3.9-3.11, how are we making sure that it will e tested for all variants?
@gforcada hints?
@MrTango i have setup a matrix, see my comment here |
i think a new release is needed. Only for Plone 6 and higher.
some things should be do:
update readmeupdate the norobot macromore tests