Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Package with plone/meta - introduce only Plone 6 support #26

Merged
merged 45 commits into from
Jun 12, 2024

Conversation

1letter
Copy link
Collaborator

@1letter 1letter commented Apr 19, 2024

  • refactor package with plone/meta
  • update imports, linting and code format
  • remove buidlout related files
  • remove deprecated imports plone.app.z3cform
  • add mx.ini
  • add a browserlayer
  • make the widget BS5 ready, use floating labels https://getbootstrap.com/docs/5.2/forms/floating-labels/

i think a new release is needed. Only for Plone 6 and higher.

some things should be do:

  • news support
  • update readme
  • update the norobot macro
  • more tests

@1letter 1letter linked an issue Apr 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 22, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@1letter 1letter marked this pull request as ready for review April 29, 2024 11:04
@1letter 1letter requested a review from erral April 29, 2024 11:05
@erral erral requested a review from gforcada April 29, 2024 11:45
Copy link
Member

@erral erral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this OK but I am not used to the new non-buildout-way of organizing the package. So I will request our meta-master a review.

In any case this requires increasing the version number to the next major version.

@1letter 1letter requested a review from MrTango May 7, 2024 07:59
@MrTango
Copy link
Contributor

MrTango commented May 7, 2024

I'm not so sure that i would remove buildout at this point, for development setups.
It is robust and well known.
There is not much advantages in change this here.
But if you change it, make sure that it is very clear how to do all the things we use to be able to do with a traditional setup.
So far i have seen a bit of a wild west in new buildout free setups.
We need well documented and tested standards here.
When we reach this point, we could also rework the plonecli templates to use the new approach.
But i would like to see it really working well for a while, before going there.

@1letter
Copy link
Collaborator Author

1letter commented May 7, 2024

@MrTango is there a roadmap for the switch? I see the plone/meta config in many packages of the plone.xxx namespace. Plone's containers are pip-based. I didn't know what the right way was. I use pip based setups with mxdev in all my packages and have no problems. but this is a discussion with religious potential ;-)

@MrTango
Copy link
Contributor

MrTango commented May 7, 2024

Ok, i had a look at the current meta setup, looks good and is recommended also for addons.
If everything works and the README points the developers in the right direction, all good.
I'll have a closer look and play with it as soon as i can.
Eventually, this will become also standard for addons made by plonecli.
But I'm not in a hurry with it.
Let's battle proof it before we do that.

Copy link
Contributor

@MrTango MrTango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we define the test Matrix here?
We state that this will run in Plone 6.0/6.1 and Python 3.9-3.11, how are we making sure that it will e tested for all variants?
@gforcada hints?

@1letter
Copy link
Collaborator Author

1letter commented May 7, 2024

@MrTango i have setup a matrix, see my comment here

@MrTango MrTango self-requested a review June 12, 2024 12:48
@MrTango MrTango merged commit 1c2b3f6 into master Jun 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plone 6 plone.app.discussion form the question is not change on reload
3 participants