-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add __all__ variables to some modules #690
Conversation
@devdanzin could you have a look? If you see anything you would like to improve, please create a pull request to this one or suggest edits (I do not know how to do the last one) It could also be merged and another one created... @c0d33ngr The tests are failing but I think that this is not your fault. I reported an issue: #677 Thanks for contributing so we can catch that problem with out CI setup!
Could you create a changelog entry for the next release? |
Sure, I'll check the names against imports and any comments regarding whether they are public. I've suggest an edit to remove dateutil, I think @c0d33ngr only has to accept the suggested changes and they will be automatically merged. |
Not from this PR, but in icalendar/src/icalendar/__init__.py Line 52 in 7fb1567
@c0d33ngr, would you like me to add |
Yeah... Please do for the prop.py |
@c0d33ngr and @devdanzin Thanks for collaborating on this PR. We are watching the test runs because I reported that they fail and I do not know what to do: coverallsapp/github-action#217 So, thanks for working as contributors so that people in the future do not get broken test results. |
Pull Request Test Coverage Report for Build 9856530008Details
💛 - Coveralls |
If you'd like me to push dummy commits (in a new PR, I guess) so coveralls runs and you can get more data points, let me know. |
Thanks for the help. I think, any work you do together here will create a new commit and then, we know more. There is no urgency and you do not have to consider that in a special way. I just wanted to let you know :) If you like to take up another issue though, we might find that other commits you make might show the same symptoms ;) |
Thank you for the code review you did and also taking up the |
Thank you for being so receptive! Unfortunately I cannot push to this PR, so I've created a PR against it: c0d33ngr#1. The same changes that go into that one go to #693 to see if I can trigger coveralls failures, but no luck so far :( |
Oh.. Okay. What can I do to assist? |
@c0d33ngr, have a look here: c0d33ngr#1 there are some proposed changes. |
Add __all__ to cli.py
I merged @devdanzin branch into mine |
Thanks! |
This PR contributes to #638
📚 Documentation preview 📚: https://icalendar--690.org.readthedocs.build/