Don't check forward declarations in enum and class naming rules

colobot · Oct 3, 2015 · cf39fc5 · cf39fc5
1 parent 75dba93
commit cf39fc5
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/Rules/ClassNamingRule.cpp b/Rules/ClassNamingRule.cpp
@@ -35,7 +35,8 @@ void ClassNamingRule::RegisterASTMatcherCallback(MatchFinder& finder)
     finder.addMatcher(
         recordDecl(unless(anyOf(isExpansionInSystemHeader(),
                                 isImplicit(),
-                                isLambda())))
+                                isLambda())),
+                   isDefinition())
             .bind("recordDecl"),
         this);
 }

diff --git a/Rules/EnumNamingRule.cpp b/Rules/EnumNamingRule.cpp
@@ -20,7 +20,8 @@ void EnumNamingRule::RegisterASTMatcherCallback(MatchFinder& finder)
 {
     finder.addMatcher(
         enumDecl(unless(anyOf(isExpansionInSystemHeader(),
-                              isImplicit())))
+                              isImplicit())),
+                 isDefinition())
             .bind("enumDecl"),
         this);
 

diff --git a/Tests/class_naming_rule_test.py b/Tests/class_naming_rule_test.py
@@ -113,3 +113,10 @@ def test_ignore_lambdas(self):
                 '}'
             ],
             expected_errors = [])
+
+    def test_ignore_forward_declaration(self):
+        self.assert_colobot_lint_result(
+            source_file_lines = [
+                'struct ignore_this;'
+            ],
+            expected_errors = [])
diff --git a/Tests/enum_naming_rule_test.py b/Tests/enum_naming_rule_test.py
@@ -120,3 +120,10 @@ def test_inform_about_anonymous_enum(self):
                     'line': '3'
                 }
             ])
+
+    def test_ignore_forward_declaration(self):
+        self.assert_colobot_lint_result(
+            source_file_lines = [
+                'enum class ignore_this : int;'
+            ],
+            expected_errors = [])