fix: Connection::escapeString should escape backslashes (#197)

* fix: Connection::escapeString should escape backslashes * update changelog * fix
colopl · Mar 11, 2024 · a4870d9 · a4870d9
1 parent 13a9943
commit a4870d9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@ Changed
 - Performance enhancements for `DB::pretend` statements, no longer incurring the overhead of creating transactions (#191)
 - Set the `$defaultMorphKeyType` in `Schema\Builder` to `uuid` (#192)
 
+Fixed
+- `Connection::escapeString` now properly escapes backslashes (#197)
+
 # v7.0.0 (2024-02-21)
 
 Added

diff --git a/src/Connection.php b/src/Connection.php
@@ -482,8 +482,8 @@ protected function escapeBool($value)
     protected function escapeString($value)
     {
         return str_contains($value, "\n")
-            ? 'r"""' . addcslashes($value, '"') . '"""'
-            : '"' . addcslashes($value, '"') . '"';
+            ? 'r"""' . addcslashes($value, '"\\') . '"""'
+            : '"' . addcslashes($value, '"\\') . '"';
     }
 
     /**

diff --git a/tests/ConnectionTest.php b/tests/ConnectionTest.php
@@ -537,6 +537,7 @@ public function test_escape(): void
         $this->assertSame('-1', $conn->escape(-1));
         $this->assertSame('1.1', $conn->escape(1.1));
         $this->assertSame('"a"', $conn->escape('a'));
+        $this->assertSame('"\"a\\\\\\""', $conn->escape('"a\\"'));
         $this->assertSame('r"""' . "\n" . '"""', $conn->escape("\n"));
         $this->assertSame('[]', $conn->escape([]));
         $this->assertSame('["a"]', $conn->escape(['a']));