Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: phpstan error for string('column', 'MAX') #223

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix: phpstan error for string('column', 'MAX') #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aba4424
fix: phpstan error for string('column', 'MAX')
taka-oyama Jun 24, 2024
288f348
fix
taka-oyama Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# v8.1.3 (2024-06-24)

Fixed
- phpstan error for string('column', 'MAX') (#223)

# v8.1.2 (2024-06-10)

Fixed
- updateOrInsert signature change in 11.10 (#216)

# v8.1.1 (2024-06-03)

Fixed
Expand Down
3 changes: 3 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,6 @@ parameters:
- message: "#^Cannot access offset 'requestTag' on mixed\\.$#"
count: 1
path: src/Connection.php
- message: "#^Parameter \\#2 \\$length of method Illuminate\\\\Database\\\\Schema\\\\Blueprint\\:\\:string\\(\\) expects int\\|null, int\\|string\\|null given\\.$#"
count: 1
path: src/Schema/Blueprint.php
9 changes: 9 additions & 0 deletions src/Schema/Blueprint.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,15 @@ public function tinyIncrements($column)
return $this->increments($column);
}

/**
* @inheritDoc
* @param int|'max'|null $length add support for 'max'
*/
public function string($column, $length = null)
{
return parent::string($column, $length);
}

/**
* @inheritDoc
* @return UuidColumnDefinition
Expand Down
Loading