Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add Discord link to nav links #533

Merged
merged 2 commits into from
May 29, 2024

Conversation

MysteryBlokHed
Copy link
Member

Related issue: #412

This change uses the Discord invite linked from the referenced issue. Currently, the only change is adding a link to the navbar. I could also add some kind of "need help?" section to the homepage that's harder to miss, if that'd be desired.

Related issue: #412

This uses the Discord invite linked from the referenced issue.
Copy link

netlify bot commented May 29, 2024

Deploy Preview for colorjs ready!

Name Link
🔨 Latest commit 7dc403e
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/6656a869b76c2a0008064460
😎 Deploy Preview https://deploy-preview-533--colorjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This is what I meant to do at first, but I didn't notice the `footer`
class when I copied the `<a>` tag.
@MysteryBlokHed MysteryBlokHed requested a review from LeaVerou May 29, 2024 12:59
Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's go with that for now and see how it goes.

@MysteryBlokHed MysteryBlokHed merged commit 7409b34 into color-js:main May 29, 2024
4 of 5 checks passed
@MysteryBlokHed MysteryBlokHed deleted the site/discord-link branch May 29, 2024 19:15
@MysteryBlokHed
Copy link
Member Author

I know I've already merged this, but I wonder if it might be better to use a unique invite link for the website? That way it's easier to tell where new members are coming from based on the link they used, if that data is of interest

@LeaVerou
Copy link
Member

Sure, why not? How though?

@MysteryBlokHed
Copy link
Member Author

Under the Color.js server > Server Settings > Invites, a full list of invite links and their use count can be seen:

Screenshot of the Invites page, showing a single invite and its use count (23)

If you're interested, then you could create a new link as usual (eg. right-clicking on a channel > Invite People) and then either edit the link in the navbar, or share it with me so I can make the change. The only reason I'd ask you to create the invite instead of doing it myself is so that it shows "Lea Verou invited you to..." instead of my own name while joining.

Also, while creating the invite, make sure to set it not to expire (there's a tiny hyperlink at the bottom of the invite menu to configure the expiration)—we don't want to just have a broken link in the navbar :P

@MysteryBlokHed
Copy link
Member Author

MysteryBlokHed commented May 29, 2024

You can't actually see which invite a specific user used without a third-party bot, but I think it's still worth doing so that we can see where people are coming from

Clarification: I don't mean adding a bot; I mean making a unique invite link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants