Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actions-branch-descendant.sh #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update actions-branch-descendant.sh #8

wants to merge 2 commits into from

Conversation

haitiangk92
Copy link

No description provided.

@haitiangk92 haitiangk92 marked this pull request as ready for review May 5, 2022 21:08
@nafarlee
Copy link
Member

nafarlee commented May 6, 2022

@haitiangk92
Considering some repositories may still be using master, and some repositories could be using an entirely different default branch name (like prod or something), would it make more sense if the action took an input that specified what the "root" branch was? In that case, I think making it optional and defaulting to main would be alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haitiangk92 @nafarlee