Suppress warnings that phantomjs was not found in $PATH #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is no system wide installed phantomjs you always get a warning that there is no phantomjs installed, but the tests still work fine by using the version from the user's home. That's annyoing and confusing and thus these warnings are now suppressed by piping them to /dev/null.
aduffeck
added a commit
to SUSE/machinery
that referenced
this pull request
Oct 1, 2015
An according pull request was made upstream at colszowka/phantomjs-gem#61
aduffeck
added a commit
to SUSE/machinery
that referenced
this pull request
Oct 1, 2015
An according pull request was made upstream at colszowka/phantomjs-gem#61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no system wide installed phantomjs you always get a
warning that there is no phantomjs installed, but the tests still work
fine by using the version from the user's home.
That's annyoing and confusing and thus these warnings are now suppressed
by piping them to /dev/null.