Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the downloaded archive was extracted #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make sure the downloaded archive was extracted #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 43 additions & 24 deletions lib/phantomjs/platform.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,34 +39,12 @@ def installed?
File.exist?(phantomjs_path) || system_phantomjs_installed?
end

# TODO: Clean this up, it looks like a pile of...
def install!
STDERR.puts "Phantomjs does not appear to be installed in #{phantomjs_path}, installing!"
FileUtils.mkdir_p Phantomjs.base_dir

# Purge temporary directory if it is still hanging around from previous installs,
# then re-create it.
temp_dir = File.join(temp_path, 'phantomjs_install')
FileUtils.rm_rf temp_dir
FileUtils.mkdir_p temp_dir

Dir.chdir temp_dir do
unless system "curl -L --retry 5 -O #{package_url}" or system "wget -t 5 #{package_url}"
raise "\n\nFailed to load phantomjs! :(\nYou need to have cURL or wget installed on your system.\nIf you have, the source of phantomjs might be unavailable: #{package_url}\n\n"
end

case package_url.split('.').last
when 'bz2'
system "bunzip2 #{File.basename(package_url)}"
system "tar xf #{File.basename(package_url).sub(/\.bz2$/, '')}"
when 'zip'
system "unzip #{File.basename(package_url)}"
else
raise "Unknown compression format for #{File.basename(package_url)}"
end

# Find the phantomjs build we just extracted
extracted_dir = Dir['phantomjs*'].find { |path| File.directory?(path) }
download(package_url)
extracted_dir = extract(package_url)

# Move the extracted phantomjs build to $HOME/.phantomjs/version/platform
if FileUtils.mv extracted_dir, File.join(Phantomjs.base_dir, platform)
Expand All @@ -85,6 +63,47 @@ def install!
def ensure_installed!
install! unless installed?
end

private

def download(package_url)
unless system "curl -L --retry 5 -O #{package_url}" or system "wget -t 5 #{package_url}"
raise "\n\nFailed to load phantomjs! :(\nYou need to have cURL or wget installed on your system.\nIf you have, the source of phantomjs might be unavailable: #{package_url}\n\n"
end
end

def extract(package_url)
basename = File.basename(package_url)

case package_url.split('.').last
when 'bz2'
system "bunzip2 #{basename}"
system "tar xf #{basename.sub(/\.bz2$/, '')}"
when 'zip'
system "unzip #{basename}"
else
raise "Unknown compression format for #{basename}"
end

# Find the phantomjs build we just tried to extracted
extracted_dir = Dir['phantomjs*'].find { |path| File.directory?(path) }
# If it's not there then extraction failed
raise "Failed to extract archive #{basename}" unless extracted_dir

extracted_dir
end

def temp_dir
FileUtils.mkdir_p Phantomjs.base_dir

# Purge temporary directory if it is still hanging around from previous installs,
# then re-create it.
dir = File.join(temp_path, 'phantomjs_install')
FileUtils.rm_rf dir
FileUtils.mkdir_p dir

dir
end
end

class Linux64 < Platform
Expand Down