Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implode Phantomjs when installed in custom base dir. #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/phantomjs.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def platform

# Removes the local phantomjs copy
def implode!
FileUtils.rm_rf File.join(File.expand_path('~'), '.phantomjs')
FileUtils.rm_rf base_dir
end

# Clears cached state. Primarily useful for testing.
Expand Down
11 changes: 10 additions & 1 deletion spec/phantomjs_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,13 @@
lines.should eq(["bar foo1\n", "bar foo2\n"])
end
end
end

describe ".implode!" do
it "removes the local phantomjs copy from custom base_dir" do
Phantomjs.base_dir = '/tmp/base_dir'
Phantomjs.path.platform.installed?.should be_true
Phantomjs.implode!
Dir.exist?('/tmp/base_dir').should be_false
end
end
end