Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom headers and query params in connection #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heilmela
Copy link
Contributor

Im evaluating the use of colyseus in a "service mesh"-ish topology where the authn/authz is happening on reverse proxy level. That means websocket upgrade requests + all http requests need a token header or access token in the url query params to pass through the proxy and reach the colyseus upstream. (This is especially useful when scaling horizontally since colyseus replicas do NOT need to deal with authn/authz themselves)

This change would be backwards compatible by allowing optional query parms/headers to be added to every request.

@endel WDYT

i would add mock httpie and add tests if the provided headers are landing on the outgoint http requests, if you consider merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant