Custom headers and query params in connection #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im evaluating the use of colyseus in a "service mesh"-ish topology where the authn/authz is happening on reverse proxy level. That means websocket upgrade requests + all http requests need a token header or access token in the url query params to pass through the proxy and reach the colyseus upstream. (This is especially useful when scaling horizontally since colyseus replicas do NOT need to deal with authn/authz themselves)
This change would be backwards compatible by allowing optional query parms/headers to be added to every request.
@endel WDYT
i would add mock httpie and add tests if the provided headers are landing on the outgoint http requests, if you consider merging