Add in place reconnection functionality for auto-reconnect on "abnormal closure" (error 1006) #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
My reasoning for adding a new event handler
onClose
is to not alter the function of existing codebases.onClose
handler will happen when the connection closes beforeonLeave
and will cancel leaving and destroying the room if an error is thrown within the callback.client.reconnect<T>(room: Room<T>)
is a new overload.It will connect in place to an existing room the user is already connected to, therefore not invalidating the state of the existing room and allowing it to be reused.