add FIXME/workaround comment for .listen() as well. #147

colyseus · Mar 30, 2024 · 4ff57bd · 4ff57bd
1 parent c29b5c9
commit 4ff57bd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/decoder/strategy/StateCallbacks.ts b/src/decoder/strategy/StateCallbacks.ts
@@ -169,7 +169,12 @@ export function getStateCallbacks(decoder: Decoder) {
             return new Proxy({
                 listen: function listen(prop: string, callback: (value: any, previousValue: any) => void, immediate: boolean = true) {
                     // immediate trigger
-                    if (immediate && context.instance[prop] !== undefined) {
+                    if (
+                        immediate &&
+                        context.instance[prop] !== undefined &&
+                        !isTriggeringOnAdd // FIXME: This is a workaround
+                                           // (https://github.com/colyseus/schema/issues/147)
+                    ) {
                         callback(context.instance[prop], undefined);
                     }
                     return $root.addCallback(

diff --git a/src/v3.ts b/src/v3.ts
@@ -383,9 +383,9 @@ $(decoder.state).teams.onAdd((team, index) => { // delayed
     $(team).entities.onAdd((entity, entityId) => {
         console.log(`Entities.onAdd =>`, { teamIndex: index, entityId, refId: decoder.$root.refIds.get(entity) });
 
-        // $(entity).onChange(() => {
-        //     console.log("Entity changed!");
-        // });
+        $(entity).onChange(() => {
+            console.log("Entity changed!");
+        });
 
         $(entity).listen("position", (value, previousValue) => {
             console.log("entity position ->", value.toJSON());