Add scala 3 compiler settings test #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lefou should I also add also this hint comment to 2.12: @ // interp.preConfigureCompiler(ctx => ctx.setSetting(ctx.settings.YnoImports, true)) // Dotty |
I've no idea. |
lefou
reviewed
May 8, 2024
|
@lefou there is a note regarding this test not working on 2.13: // not sure why that one doesn't pass in 2.13
// even disabling the noimports and imports settings instead of setting noimports to false
// doesn't seem to reinstate imports
def sv = scala.util.Properties.versionNumberString
// In 2.12.13, I would have expected things like
// interp.configureCompiler(_.settings.Wconf.tryToSet(List("any:wv", "cat=unchecked:ws")))
// to re-instate the expected warning below, to no avail :|I could check this later and verify if we can at least add newer 2.12 versions as part of other MR. |
Yrangepos default was changed between 2.13 versions
carlosrogue
force-pushed
the
scala3-compiler-settings
branch
from
0dda475
to
1d1d3d8
Compare
carlosrogue
commented
May 8, 2024
| @@ -143,7 +143,7 @@ object BuiltinTests extends TestSuite { | |||
| // In 2.12.13, I would have expected things like | |||
| // interp.configureCompiler(_.settings.Wconf.tryToSet(List("any:wv", "cat=unchecked:ws"))) | |||
| // to re-instate the expected warning below, to no avail :| | |||
| if (TestUtils.scala2_12 && sv.stripPrefix("2.12.").toInt <= 12) { | |||
| if (TestUtils.scala2_12 && sv.stripPrefix("2.12.").toInt <= 19) { | |||
There was a problem hiding this comment.
Do you know or have an idea why the test isn't configured for Scala 2.13? Also newer Scala 2.12 version aren't covered?
@lefou after covering until 2.12.19 this was successful: mill 'amm.repl[2.12.{13,14,15,16,17,18,19}].test.testOnly' -- 'ammonite.session.BuiltinTests.settings'.
carlosrogue
force-pushed
the
scala3-compiler-settings
branch
from
bd56404
to
c0b9cd4
Compare
lefou
pushed a commit
that referenced
this pull request
Jul 17, 2024
Enable settings tests for any 2.12 versions. This is a follow up of this conversation #1484 (review) I had previously with @lefou. Tested with `mill -i -w 'amm.repl[{2.12.19,2.13.14,3.4.2}].test.testOnly' -- 'ammonite.session.BuiltinTests.settings'` so all `2.12`, `2.13` and `3` latest versions are passing. Pull request: #1516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official Compiler Flags documentation do not mention how to set settings for scala 3 compiler.
Maybe adding a comment like this in 2.12?:
Fixes #1192