Specify exact files to process in ktlint run #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
sideeffffect
reviewed
Jan 3, 2025
| ): Command[Unit] = Task.Command { | ||
| ktlintAction( | ||
| KtlintArgs(format = false, check = check.value), | ||
| KtlintArgs(format = false, check = false), |
There was a problem hiding this comment.
Just a guess, but isn't this a typo? Shouldn't this be
KtlintArgs(format = false, check = true),There was a problem hiding this comment.
good catch, it is a copy-paste typo here. #4247
sideeffffect
reviewed
Jan 3, 2025
| ): Command[Unit] = Task.Command { | ||
| ktlintAction( | ||
| KtlintArgs(format = true, check = check.value), | ||
| KtlintArgs(format = true, check = true), |
There was a problem hiding this comment.
Just a guess, but isn't this a typo? Shouldn't this be
KtlintArgs(format = true, check = false),There was a problem hiding this comment.
no, because check flag controls exit code handling (see
mill/kotlinlib/src/mill/kotlinlib/ktlint/KtlintModule.scala
Lines 136 to 140 in d2df820
There was a problem hiding this comment.
Oh, I see, cool, thank :)
lihaoyi
pushed a commit
that referenced
this pull request
Jan 5, 2025
Fix small typo made in #4201 - `checkFormalAll` task should fail in case of formatting violations. Co-authored-by: 0xnm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
ktlintsupport: it explicitly specifies the files to process.Without that current
mill.kotlinlib.ktlint.KtlintModule/checkFormatAllrun, for example, will go through the files under theoutfolder, which is useless and pollutes logs.Also this PR removes redundant flags from
reformatAllandcheckFormatAll: former will always be withformat=trueby definition, the latter will always be withformat=false.