Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scalafmt #179

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Add scalafmt #179

merged 4 commits into from
Jan 8, 2025

Conversation

lqhuang
Copy link
Contributor

@lqhuang lqhuang commented Dec 30, 2024

Nothing changes besides codes been formatted.

I copied .scalafmt from mill and did very little tunings for consistency and readability.

My local test results

$ ./mill -i __.publishArtifacts + __.test

[418/420] requests[2.13.15].test.test
[418] 
[420/420] requests[3.3.4].test.test
[420] 
[417/420] requests[2.12.20].test.test
[417] 
[420/420] ==================================================================== __.publishArtifacts + __.test ======================================================================= 1s

My local binary compatibility check results

$ ./mill -i __.mimaReportBinaryIssues
[build.mill-64/68] compile
[build.mill-64] [info] compiling 1 Scala source to /home/lqhuang/Git/requests-scala/out/mill-build/compile.dest/classes ...
[build.mill-64] [info] done compiling
[211/212] requests.jvm[2.12.20].mimaReportBinaryIssues
[210/212] requests.jvm[2.13.15].mimaReportBinaryIssues
[212/212] requests.jvm[3.3.4].mimaReportBinaryIssues
[211] Scanning binary compatibility in /home/lqhuang/Git/requests-scala/out/requests/jvm/2.12.20/compile.dest/classes ...
[210] Scanning binary compatibility in /home/lqhuang/Git/requests-scala/out/requests/jvm/2.13.15/compile.dest/classes ...
[212] Scanning binary compatibility in /home/lqhuang/Git/requests-scala/out/requests/jvm/3.3.4/compile.dest/classes ...
[210] Binary compatibility check passed
[211] Binary compatibility check passed
[212] Binary compatibility check passed
[212/212] ============================== __.mimaReportBinaryIssues ============================== 8s

@lqhuang lqhuang marked this pull request as ready for review January 4, 2025 10:40
@lqhuang
Copy link
Contributor Author

lqhuang commented Jan 8, 2025

@lihaoyi Already rebased from current master. All checks have passed. Also ready to merge. Any style feedback is welcome.

Regards

@lihaoyi lihaoyi merged commit 6047541 into com-lihaoyi:master Jan 8, 2025
5 checks passed
@lihaoyi
Copy link
Member

lihaoyi commented Jan 8, 2025

thanks!

@lqhuang lqhuang deleted the add-scalafmt branch January 8, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants