OPIK-904: Split find project endpoint into two endpoints find and stats #1176
Conversation
thiagohora
force-pushed
the
thiagohora/OPIK-904_split_find_project_into_find_and_stats_endpoint
branch
from
a9805a0 to
563ff2d
Compare
| @@ -188,7 +190,7 @@ public Response deleteById(@PathParam("id") UUID id) { | |||
| @ApiResponse(responseCode = "400", description = "Bad Request", content = @Content(schema = @Schema(implementation = ErrorMessage.class))), | |||
| @ApiResponse(responseCode = "404", description = "Not Found", content = @Content(schema = @Schema(implementation = ErrorMessage.class))) | |||
| }) | |||
| @JsonView({Project.View.Public.class}) | |||
| @JsonView({Project.View.Detailed.class}) | |||
There was a problem hiding this comment.
There is no test that verifies fields marked with Detailed view, returned by this endpoint.
There was a problem hiding this comment.
The test remains the same since this endpoint didn't change; only the. find was affected
There was a problem hiding this comment.
Yes, old test also didn't check it. So we basically never verified that those values(now annotated with Detailed) are returned properly by this endpoint. I suppose it should be added to corresponding test.
There was a problem hiding this comment.
Ok, let me check it
thiagohora
force-pushed
the
thiagohora/OPIK-904_split_find_project_into_find_and_stats_endpoint
branch
from
563ff2d to
f21e92c
Compare
thiagohora
force-pushed
the
thiagohora/OPIK-904_split_find_project_into_find_and_stats_endpoint
branch
from
f21e92c to
79756fe
Compare
| @Builder(toBuilder = true) | ||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| @JsonNaming(PropertyNamingStrategies.SnakeCaseStrategy.class) | ||
| public record ProjectStatsSummary(List<ProjectStatsSummaryItem> content) { |
There was a problem hiding this comment.
Minor: this could be a lightweight Page object, with page, size on top of the current content and without total. But this works as FE is fine with it. We can always extend it in the future.
There was a problem hiding this comment.
Sure, we can add in the next iteration
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
thiagohora
force-pushed
the
thiagohora/OPIK-904_split_find_project_into_find_and_stats_endpoint
branch
from
3480e68 to
56099b2
Compare
thiagohora
deleted the
thiagohora/OPIK-904_split_find_project_into_find_and_stats_endpoint
branch
Details
We are splitting this endpoint to optimize the critical path rendering
Also, two remaining orders by clause from the spans and traces queries were removed.
Issues
OPIK-904