Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-964] home page improvements #1233

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

awkoy
Copy link
Contributor

@awkoy awkoy commented Feb 6, 2025

Details

  • feedback scores tag UI fixes
  • round feedback scores value to 3
  • remove columns from home page
  • show feedback scores column by default on Experiment page
  • show "-" if total cost is 0

Issues

Resolves #

Testing

Documentation

@awkoy awkoy requested a review from a team as a code owner February 6, 2025 16:16
type: COLUMN_TYPE.number,
},
{
id: "feedback_scores",
label: "Feedback scores",
type: COLUMN_TYPE.numberDictionary,
accessorFn: (row) => get(row, "feedback_scores", []),
accessorFn: (row) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should apply formatNumericData in FeedbackScoreListCell since we are likely to have some tooltip there in the near future to show a full number and it is related to formatting data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it once needed, in the next iterations =)

@aadereiko aadereiko self-requested a review February 6, 2025 16:46
@awkoy awkoy merged commit 6713937 into main Feb 6, 2025
2 checks passed
@awkoy awkoy deleted the awkoy/OPIK-964-home-page-improvements branch February 6, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants