Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick-n-dirty creation of a submodule for packing up dojo sources. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddumont
Copy link

@ddumont ddumont commented Oct 2, 2013

Example output generates:
dojo-src-1.9.2-SNAPSHOT.tar.bz2
dojo-src-1.9.2-SNAPSHOT.tar.gz
dojo-src-1.9.2-SNAPSHOT.zip

@gregw
Copy link
Member

gregw commented Oct 2, 2013

Thanks for the contribution.

I'll have a look at this in detail probably next week.... however my first thought was that I was intending to have the source as an extra artefact produced from the dojo module, rather than as an entirely new module.

But it may be that you have the secret sauce in your pom that will enable this

@ddumont
Copy link
Author

ddumont commented Oct 4, 2013

ok I see. Perhaps we could download both artifacts from dojo and extract them both and package them both in the same dojo build. I thought those wanting to do the maven build manually might want to do one or the other.

At which point you would use profiles... I wasn't sure what you wanted to do and thought a new submodule might be more straightforward, but if you rather another way, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants