Add download example link to interface form field #3823
+121
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is how the download example link looks now
|
chrisvanrun
reviewed
Feb 11, 2025
app/grandchallenge/components/templates/components/partials/example_download_link.html
Outdated
Show resolved
Hide resolved
chrisvanrun
requested changes
Feb 11, 2025
app/grandchallenge/components/templates/components/partials/example_download_link.html
Outdated
Show resolved
Hide resolved
app/grandchallenge/components/templates/components/partials/example_download_link.html
Show resolved
Hide resolved
ammar257ammar
commented
Feb 14, 2025
| self.kwargs["widget"] = FlexibleFileWidget( | ||
| help_text=self.help_text, | ||
| help_text=_join_with_br(self.help_text, extra_help), |
There was a problem hiding this comment.
After the new implementation of file widget #8ae9479
The download link is not showing correctly.
Looking into it.
There was a problem hiding this comment.
Thomas is still in the process of heavily refactoring the logic there, so maybe best to wait until he is done.
There was a problem hiding this comment.
Got it, I will wait then.
chrisvanrun
reviewed
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3809