-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split off the Ground Truth page #3853
Conversation
It is not the case for algorithms, we do not have such a feature anywhere. Please do not do large refactoring like that without discussion in a pitch first. |
app/grandchallenge/reader_studies/templates/reader_studies/readerstudy_ground_truth.html
Outdated
Show resolved
Hide resolved
Definitively! I thought I should mention this here as it would be a sensible comment to have on a split-from-tab PR. I thought algorithms implemented it already but it actually are the Challenge admin pages (i.e. phase settings, general config, et cetera) that do that. |
Given the changes were out of style with the other apps and it was suggested to update them, I've taken the oppertunity to update the style of permissions and route param typing within the reader study app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Part of the pitch:
A quick pre-lude:
Other than above, I did not change the content of the page.
Considered to refactor all reader study views to have the configuration side-panel, much like the algorithms. But have put that out of scope (for now).
Showcase
The warning is no longer there.