Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][DEVX-364] Record Custom Metric (Response Time) #861

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ajimae
Copy link
Contributor

@ajimae ajimae commented Nov 27, 2024

Summary

Record custom metrics (request-response time)

Completed Tasks

  • add a helper to get individual request start and end times
  • add APM agents to record and send custom metrics to respective APMs

- record and send custom metrics to respective APMs
@ajimae ajimae requested a review from a team as a code owner November 27, 2024 00:00
Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 6e60c49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@commercetools/ts-sdk-apm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ajimae ajimae marked this pull request as draft November 27, 2024 00:01
@ajimae ajimae changed the title [Feat][Dev-364] Record Custom Metric (Response Time) [Feat][DEVX-364] Record Custom Metric (Response Time) Nov 27, 2024
- fix tests for old (legacy) apm middleware
@ajimae ajimae force-pushed the feat/add-requests-response-time-and-custom-metrics branch from e834325 to 5f7d9bb Compare November 27, 2024 00:17
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.07%. Comparing base (878aacc) to head (5f7d9bb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #861   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files          25       25           
  Lines         289      289           
  Branches       14       14           
=======================================
  Hits          269      269           
  Misses         20       20           
Flag Coverage Δ
integrationtests 93.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- improve typescript types for ts-sdk-apm package
- add more custom metric example snippets to example directory
- add tests to validate functionality
@ajimae ajimae marked this pull request as ready for review November 27, 2024 15:36
@ajimae ajimae force-pushed the feat/add-requests-response-time-and-custom-metrics branch from b63f0b8 to 8fb70b5 Compare November 27, 2024 15:39
- add node-fetch dependency to apm package
@ajimae ajimae marked this pull request as draft November 27, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant