Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate a build info class with version property #961

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jenschude
Copy link
Contributor

Summary

Generates a BuildInfo class file with the version of the library

Description

At the moment the SyncSolutionInfo file is updated by a task which uses ant to replace a placeholder with the actual build version number.

By generating a class file before the compilation step we can ensure that this file is always there and holds the version of the package. So the error prone pattern matching can be dropped.

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Merging #961 (ec3ee88) into master (feec854) will not change coverage.
The diff coverage is n/a.

❗ Current head ec3ee88 differs from pull request most recent head 9e36697. Consider uploading reports for the commit 9e36697 to get more accurate results

@@            Coverage Diff            @@
##             master     #961   +/-   ##
=========================================
  Coverage     99.12%   99.12%           
  Complexity     2690     2690           
=========================================
  Files           225      225           
  Lines          7206     7206           
  Branches        450      450           
=========================================
  Hits           7143     7143           
  Misses           31       31           
  Partials         32       32           
Impacted Files Coverage Δ
...ercetools/sync/commons/utils/SyncSolutionInfo.java 100.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants