Expose the QueuePusher API
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to the `QueuePuller` API defined in #6, the publication API is modeled around a sink and a `QueuePusher`. The pusher is the lowest level API of publication, allowing existing code bases to choose how the messages are published. The sink provided in the `QueuePubliser` allows for integrating into existing fs2 code easily. This approach brings regularity to the API and symmetry between publication and subscription.
JPisCoding
reviewed
Mar 7, 2024
...e/service-bus/src/main/scala/com/commercetools/queue/azure/servicebus/ServiceBusPusher.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to the
QueuePullerAPI defined in #6, the publication API is modeled around a sink and aQueuePusher. The pusher is the lowest level API of publication, allowing existing code bases to choose how the messages are published. The sink provided in theQueuePubliserallows for integrating into existing fs2 code easily.This approach brings regularity to the API and symmetry between publication and subscription.