fix(ExitCode): add from_str in ExitCode and replace parse_no_raise with it, warn if the error code is not in range #1545
+60
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4-9-0-test #1545 +/- ##
==============================================
Coverage ? 97.98%
==============================================
Files ? 58
Lines ? 2680
Branches ? 0
==============================================
Hits ? 2626
Misses ? 54
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
no_raise
branch
3 times, most recently
from
39b824e to
5425115
Compare
bearomorphism
changed the title
Lee-W
reviewed
Jul 6, 2025
commitizen/exceptions.py
Outdated
| if value.isdecimal(): | ||
| try: | ||
| return cls(int(value)) | ||
| except ValueError: |
There was a problem hiding this comment.
instead of returning None, I think we should raise error and handles it in commitizen/cli.py instead
There was a problem hiding this comment.
I know it might make the code longer, but makes more sense IMO
There was a problem hiding this comment.
oh I misunderstood. I'll fix it
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
…th it Warn if a given decimal string is not in range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and tests