-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browser template docs #43
base: main
Are you sure you want to change the base?
Conversation
--console --exec --pass-through --un --verbose -e -u | ||
``` | ||
|
||
Type `assume -s ` and press **tab** to see service names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there something required to enable this? I've run granted completion -s zsh
but it doesn't seem to work
Co-authored-by: Calvin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should split this into two separate PRs: one to add the browser template guide and a second PR to improve our config docs.
I'm not sure if the approach in this PR of splitting the config page up into a subfolder is ideal. We currently have a "Usage" section and a "Recipes" section. A lot of the content in the Config section may be better placed inside of "Usage"? (and we should consider removing Recipes, perhaps?)
What I'd propose we do instead is reduce the content in the configuration page, and have it just focused on the ~/.granted/config
file. e.g. we should show an example config, and explain what each section in the config does. Everything else should be shifted to Usage.
…cs into add-browser-template-docs
Thanks @chrnorm good feedback. I have altered the change to move all the new pages to under the usage folder + removed the recipes section and moved those pages to under usage as well. I think this is much easier to find all the usage features in one place Another thing I was thinking was making integrations with Common Fate easier to find. There has been a couple times where users were unable to find the relevant documentation and resorted to asking us directly. Keen for your thoughts here. Happy to scrap it / move it into a separate PR if you'd like that as well. |
In this PR I also updated the configuration docs to be separated out into different pages to help with discoverability