Skip to content

Commit

Permalink
Fix Commonality Studio constraints sidebar and navigation links (#183)
Browse files Browse the repository at this point in the history
* Fixes the "Feedback" and "Docs" links to point to new website
* Fixes the `defaultSize` props for react-resizeable-panels so that
total adds up to `100`.
* Fixes the hover interaction for nodes on the constraint graph
  • Loading branch information
alec-chernicki authored Jan 4, 2024
1 parent 7d4d5a1 commit 202b591
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 5 deletions.
7 changes: 7 additions & 0 deletions .changeset/wicked-spoons-compare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@commonalityco/utils-constraints": patch
"@commonalityco/ui-constraints": patch
"@commonalityco/studio": patch
---

Fixes initialization issues with Commonality Studio and broken links
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ lib-cov
.node_repl_history
.yarn-integrity


# Serverless directories
.serverless/

Expand All @@ -60,6 +61,7 @@ lib-cov

# Build
lib
.nx
.next
.turbo
storybook-static/
6 changes: 3 additions & 3 deletions apps/studio/src/app/studio-navigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function StudioNavigation({
<div className="flex items-center space-x-2">
<Button variant="link" asChild>
<Link
href="https://commonality.co/feedback"
href="https://github.com/commonalityco/commonality/issues/new?title=Feedback+for+%22Commonality+Studio%22&labels=feedback"
target="_blank"
rel="noopener noreferrer"
>
Expand All @@ -69,11 +69,11 @@ function StudioNavigation({
</Button>
<Button variant="link" asChild>
<Link
href="https://commonality.co/docs"
href="https://commonality.co/docs/overview"
target="_blank"
rel="noopener noreferrer"
>
Docs
Documentation
</Link>
</Button>
<ThemeButton
Expand Down
2 changes: 1 addition & 1 deletion packages/constraints/ui-constraints/src/sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ export function Sidebar({
onLayout={onLayout}
>
<Panel
defaultSize={defaultLayout?.[0] ?? 33}
defaultSize={defaultLayout?.[0] ?? 34}
minSize={5}
className="grid content-start"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const bindRenderGraphEvents = (arguments_: EventHandlerArguments) => {
renderGraph.nodes().removeListener('mouseover');
renderGraph
.nodes()
.on('mouseover, tap', (event) =>
.on('mouseover', (event) =>
handleNodeMouseover({ ...arguments_, target: event.target }),
);

Expand Down

0 comments on commit 202b591

Please sign in to comment.