Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Commonality Studio constraints sidebar and navigation links #183

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Fix Commonality Studio constraints sidebar and navigation links #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cc9874
fix: update href for navigation links
alec-chernicki Jan 3, 2024
34b3912
fix: ensure that total for defaultSize adds up to 100
alec-chernicki Jan 3, 2024
a2b215b
refactor: rename from docs to documentation
alec-chernicki Jan 4, 2024
af936f8
chore: add changeset
alec-chernicki Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/wicked-spoons-compare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@commonalityco/utils-constraints": patch
"@commonalityco/ui-constraints": patch
"@commonalityco/studio": patch
---

Fixes initialization issues with Commonality Studio and broken links
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ lib-cov
.node_repl_history
.yarn-integrity


# Serverless directories
.serverless/

Expand All @@ -60,6 +61,7 @@ lib-cov

# Build
lib
.nx
.next
.turbo
storybook-static/
6 changes: 3 additions & 3 deletions apps/studio/src/app/studio-navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function StudioNavigation({
<div className="flex items-center space-x-2">
<Button variant="link" asChild>
<Link
href="https://commonality.co/feedback"
href="https://github.com/commonalityco/commonality/issues/new?title=Feedback+for+%22Commonality+Studio%22&labels=feedback"
target="_blank"
rel="noopener noreferrer"
>
Expand All @@ -69,11 +69,11 @@ function StudioNavigation({
</Button>
<Button variant="link" asChild>
<Link
href="https://commonality.co/docs"
href="https://commonality.co/docs/overview"
target="_blank"
rel="noopener noreferrer"
>
Docs
Documentation
</Link>
</Button>
<ThemeButton
Expand Down
2 changes: 1 addition & 1 deletion packages/constraints/ui-constraints/src/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ export function Sidebar({
onLayout={onLayout}
>
<Panel
defaultSize={defaultLayout?.[0] ?? 33}
defaultSize={defaultLayout?.[0] ?? 34}
minSize={5}
className="grid content-start"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/constraints/utils-constraints/src/bind-render-graph-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const bindRenderGraphEvents = (arguments_: EventHandlerArguments) => {
renderGraph.nodes().removeListener('mouseover');
renderGraph
.nodes()
.on('mouseover, tap', (event) =>
.on('mouseover', (event) =>
handleNodeMouseover({ ...arguments_, target: event.target }),
);

Expand Down
Loading