-
Notifications
You must be signed in to change notification settings - Fork 21
fix: update dockerfile and requirements.txt to bring in line with ind… #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pywb2
Are you sure you want to change the base?
Conversation
…ex.commoncrawl.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like awscli is installed twice, once by apt and once by pip?
Well, sort of - I assume the one in requirements.txt is to support folks not using docker/installing directly on local. (That was there before my change - I just had un-commented the requirements.txt one inadvertantly) Let me try quick to confirm we can remove the docker one, and be covered only by the requirements.txt for both cases. |
A few things @wumpus bottom line up front - I actually think we should remove that install-collections script from docker build all together. details:
|
…i from docker and requirements.txt - data doesn't belong directly in docker image
@wumpus I updated Readme, requirements, and docker to be in alignment with that POV explained in last comment. |
@sebastian-nagel looking forward to your comments! |
…irements and versions for 3.9 on intel
Uh oh!
There was an error while loading. Please reload this page.