🎨 no email if no changes in team sync dry run

commonhaus · Jun 10, 2024 · 7449f2b · 7449f2b
1 parent fb09668
commit 7449f2b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/cf-admin-bot/src/main/java/org/commonhaus/automation/admin/github/TeamMemberSync.java b/cf-admin-bot/src/main/java/org/commonhaus/automation/admin/github/TeamMemberSync.java
@@ -286,6 +286,10 @@ void doSyncTeamMembers(TeamSourceConfig config, String fullTeamName, Set<String>
             finalLogins.addAll(toAdd);
             finalLogins.removeAll(toRemove);
 
+            if (toAdd.isEmpty() && toRemove.isEmpty()) {
+                // no action required
+                return;
+            }
             Logins allLogins = new Logins(currentLogins, toAdd, toRemove, finalLogins);
             sendDryRunEmail(fullTeamName, allLogins, dryRunEmail);
         }