checks items length #5360
checks items length #5360
Conversation
| final List<UploadItem> uploadItems = repository.getUploads(); | ||
| if (uploadItems.size()==0) { | ||
| view.showProgress(false); | ||
| view.showMessage("Upload Failed",R.color.color_error); |
There was a problem hiding this comment.
Please show a more technically detailed error message, explaining what is the actual issue. It is OK if users do not understand it fully.
There was a problem hiding this comment.
Thanks for your review! I changed it to view.showMessage("An out-of-sync of the number of Upload Media Detail Fragment and upload items happens.",R.color.color_error);.
There was a problem hiding this comment.
How about this?
"Internal error: Zero upload items received by the Upload Media Detail Fragment. Sorry, please upload again."
Please also add a comment saying that internationalisation is not needed because this is an internal error message.
Thanks!
There was a problem hiding this comment.
Great idea! I've completed it.
| @@ -347,4 +354,5 @@ public void showSimilarImageFragment(String originalFilePath, String possibleFil | |||
| similarImageCoordinates | |||
| ); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
no need for new line here?
Description
some changes for #5314
check the length of
items, if it is empty this app will return to the main activity after pressing the next button.Tests performed
Tested ProdDebug on pixel 6 pro with API 33.