fix Issue5847 as required（make the icon always visible and just adjust the count accordingly） #5901
Conversation
…t adjust the count accordingly,comment the setVisibility method and make pending_upload_icon always visible
| // public void setUploadIconVisibility() { | ||
| // contributionController.getFailedAndPendingContributions(); | ||
| // contributionController.failedAndPendingContributionList.observe(getViewLifecycleOwner(), | ||
| // list -> { | ||
| // updateUploadIcon(list.size()); | ||
| // }); | ||
| // } |
There was a problem hiding this comment.
Could you add a comment here and possible in other changed places linking to relevant comment on why we're doing this ? This would be helpful context to know the rationale behind this change 🙂
| // contributionController.getFailedAndPendingContributions(); | ||
| // contributionController.failedAndPendingContributionList.observe(getViewLifecycleOwner(), |
There was a problem hiding this comment.
I think we could also comment the failedAndPendingContributionList member and the corresponding getFailedAndPendingContributions as I suppose they are not used for any other purpose.
|
@bxy379987 Any chance to address Sivaraam's comments above? Thanks! :-) |
|
Ok sir, sorry, I was taking four exam this two weeks, I forgot to continue , I will improve it again before the end of this week |
…le the original code has been commented out and retained with a note for potential re-use in the future.
|
@bxy379987 would you possibly be able to continue working on this change and address Nicolas' comment? We need this MR before we proceed to the production release of v5.1.0. It's fine if you're occupied with other work, we could take it from here 🙂 |
|
I am sorry sir, I am a Asian student and I need to take my country’s civil servant exam during this vacation, which is very important to me. I sincerely apologize for not meeting expectations in my previous work and for wasting your time. I didn't even see Nicolas’s previous response, and I'm really sorry about that. But at this stage, I truly don’t have the time or energy to continue, sorry sir, thank you for giving me this oppotunity to participate your program. |
|
@bxy379987 No problem at all, thanks for your contribution, and we wish you the best for your exams! :-) |
|
The feature is now part of the app. |
comment out the setVisibility method and all calls to setVisibility method， and make pending_upload_icon always visible
Description (required)
Fixes #5847
What changes did you make and why?
Comment out the original setVisibility method and related methods, then set pending_upload_icon to visible, to ensure that the pending_upload_icon is always visible on the contribution interface, making it convenient for users
Tests performed (required)
the upload_icon is always visible
Tested {build variant, e.g. ProdDebug} on {Pixel 8} with API level {API 34}.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.