Revert back to MainScope for database and ui updates #5914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind linking to the commit that this is reverting? Thanks a lot! 🙂 |
|
How to do that? 😅 |
|
Don't worry I found it: cdc4f89#diff-2f6019450f14d4da6fa575a7edebd478f4dc0828fc14b95a2ec0b9d83104da8cL68 :-) It gives context on the revert. |
|
Thank you @nicolas-raoul |
nicolas-raoul
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5898
What changes did you make and why?
Revert back to MainScope() in the
ImageLoader.ktfile because that code block contains both UI and database operations.Tests performed (required)
Tested prodDebug on Samsung A14 with API level 34.
Screenshots (for UI changes only)
None