custom-selector: adds a button to delete the current folder in custom selector #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind fixing the conflict? Thanks! |
…esult with an ActivityResultLauncher
nicolas-raoul
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5811
What changes did you make and why?
Add functionality to enable folder deletion within the custom selector activity.
Folder Deletion Helper: encapsulates most of folder deletion logic, provides methods to confirm deletion with the user, handle deletion across different Android API levels, and display success or error messages.
CustomSelectorActivity: integrated folder deletion functionality into the custom selector activity, allowing users to select a folder and choose to delete it from the custom selector UI.
In custom selector toolbar, added overflow menu button, moved existing exceeding limit warning button a bit to the left to make space for overflow menu.
Tests performed (required)
Build variant: BetaDebug
Emulators:
Android 12.0 (S) - API 31
Android 10.0 (Q) - API 29
Android 8.0 (Oreo) - API 26
Screenshots (for UI changes only)
