Fix modification on bottom sheet's data when coming from Nearby Banner and clicked on other pins #5937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It ensures single responsibility on getIconFor method
|
Hey @nicolas-raoul, I’d like to open a draft PR for the migration of the Custom Image Selector to Jetpack Compose. This migration will address several existing issues, including:
Would it be a good idea to create a parent issue to encapsulate these related child issues? |
|
@rohit9625 Yes good idea, thanks a lot, that sounds fantastic! 🙂 |
nicolas-raoul
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5827
What changes did you make and why?
highlightNearestPlace()method fromgetIconFor()method.getIconFor()calls whenever we clicked on a pin resulting in highlighting the nearest place every time.Tests performed (required)
Tested ProdDebug on Samsung A14 with API level 34.
Screenshots (for UI changes only)
Before:
Before_Nearby_Fix.mp4
After:
After_Nearby_Fix.mp4