Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert auth package to kotlin #5966

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Convert auth package to kotlin #5966

merged 7 commits into from
Nov 28, 2024

Conversation

psh
Copy link
Collaborator

@psh psh commented Nov 27, 2024

Fixes: #5956

Tested on Pixel 9 and Samsung S24+

@nicolas-raoul
Copy link
Member

Thanks Paul! :-)
Would you mind checking this?

NotificationActivity.kt:99:51 Unresolved reference: getUserName

@psh psh force-pushed the psh/convert-auth-to-kotlin branch from b42960b to cecd948 Compare November 28, 2024 01:57
@psh
Copy link
Collaborator Author

psh commented Nov 28, 2024

Done 👍

nicolas-raoul
nicolas-raoul approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried logging out 2 times, editing depiction, uploading pic, everything working as usual.
Thanks Paul! :-)

@nicolas-raoul nicolas-raoul merged commit 0c969c3 into commons-app:main Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul nicolas-raoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration of auth package to Kotlin
2 participants
@psh @nicolas-raoul