Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-630: set up marklogic cluster to rehearse restore from backup #364

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

hugh-emerson
Copy link
Collaborator

I don't think it's worth refactoring the existing module to share code between the two.

Not sure whether it's worth merging this, or just apply (and then destory) from the branch to do the restore from backup practice run

Copy link
Contributor

@BenRamchandani BenRamchandani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think merge it since we will probably use it again. The marklogic module changes slowly enough that it shouldn't rot too much. Agree it doesn't seem worth trying to merge them except maybe the CloudFormation template if they're identical?

Slight preference to rename the module "marklogic_restore_test" or similar.

@hugh-emerson hugh-emerson marked this pull request as ready for review November 23, 2023 18:58
@hugh-emerson hugh-emerson merged commit 21c896e into main Nov 27, 2023
@hugh-emerson hugh-emerson deleted the DT-630 branch November 27, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants