Fix ML metrics #377
Merged
Fix ML metrics #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugh-emerson
approved these changes
Jan 29, 2024
BenRamchandani
force-pushed
the
fix-ml-metrics
branch
from
9c8c465 to
1ab8d1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been broken in all three environments since the update. The setup script failed to create the log group as
jqwasn't installed, presumably because the user data script hadn't finished installing it yet. I've added a wait command, though haven't tried recreating any ML instances. AWS RunCommand ignores return codes so it looks like it succeeded.The alarms didn't have insufficient_data actions, so we didn't get notified of the problem.