BAU: session management fix #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidsg
reviewed
Jan 28, 2025
Comment on lines
+108
to
+114
| let id: string; | ||
| if (request.auth && request.auth.credentials && request.auth.credentials.accountId) { | ||
| id = `${request.auth.credentials.accountId}:${request.params.id}`; | ||
| request.logger.info(`[ACTIVATE-SESSION] get user account id for the session key ${id}`); | ||
| } else { | ||
| id = `${request.yar.id}:${request.params.id}`; | ||
| } |
There was a problem hiding this comment.
this feels like an unrelated change?
edit: ah I thought this PR was just for hot reload fix. This should be two PRs - let's keep separate changes as separate PRs.
There was a problem hiding this comment.
also - I'm not convinced we do actually need this after some more investigation, see thread in forms tech 👀
There was a problem hiding this comment.
broke down to 2 pr's #122
nuwan-samarasinghe
changed the title
remove changes into different PR
nuwan-samarasinghe
force-pushed
the
bau/session-management-fix
branch
from
011e579 to
1439361
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
In this change it consists of following fixes for the form runner
<request.yar.id>:<form-name>:<application_id>but in this method there is an issue if there is a user which is trying to go through the form in a deployment time then
request.yar.idchanging and then next request it cannot see the cache so in this new implementation we have introdused account id for the cache key<request.auth.credentials.accountId>:<form-name>:<application_id>So, this change will guarantee that. user will retrieve the session from cache